feat: drop is-ip by representing IPs internally as octets #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wemeetagain
changed the title
|
@dapplion @tuyennhv ready for review |
|
this PR would be a lot nicer with a better name for the |
wemeetagain
changed the title
dapplion
commented
Nov 4, 2022
twoeths
reviewed
Nov 8, 2022
| throw new Error("invalid port for encoding"); | ||
| } | ||
| return Buffer.concat([ | ||
| Buffer.from([MessageType.PONG]), | ||
| RLP.encode([toBuffer(m.id), toBuffer(m.enrSeq), tuple, m.recipientPort]), | ||
| RLP.encode([ | ||
| // |
There was a problem hiding this comment.
Added this to force prettier into placing the arguments vertically
twoeths
approved these changes
Nov 8, 2022
|
For whoever is creating the PR to bump Lodestar to discv5 1.4.0, can you additionally add Lodestar v1.3.0 milestone to it as well? Thanks! |
dapplion
commented
Nov 11, 2022
| // 4 32 ip4 | ||
| // 41 128 ip6 | ||
| // 273 16 udp | ||
| const Protocol = { |
There was a problem hiding this comment.
What was the issue with using an enum here? 6 is much less descriptive than ip6
There was a problem hiding this comment.
its used to simplify multiaddrFromSocketAddress. PR welcome if it bothers you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation coverts IPs from string and bytes multiple times unnecessarily. This motivated the need for is-ip and ip6addr libraries.
This PR: